Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make meta functions robust to URL trailing slash #27

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Make meta functions robust to URL trailing slash #27

merged 2 commits into from
Jun 12, 2024

Conversation

shikokuchuo
Copy link
Member

Makes meta_checks() and meta_packages() robust to trailing slashes in the supplied URL.

@shikokuchuo shikokuchuo self-assigned this Jun 11, 2024
@shikokuchuo shikokuchuo requested a review from wlandau June 11, 2024 22:17
@wlandau
Copy link
Member

wlandau commented Jun 12, 2024

Thanks for this! Just one request: could we use the more general trim_url() instead of the specific trim_trailing_slash()?

@shikokuchuo
Copy link
Member Author

Ok, done.

@wlandau wlandau merged commit 9df94df into main Jun 12, 2024
11 checks passed
@wlandau wlandau deleted the dev branch June 12, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlandau wlandau wlandau approved these changes

Assignees

@shikokuchuo shikokuchuo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shikokuchuo @wlandau